Feedback/url pasted params parsed incorrectly

url pasted params parsed incorrectly

Hao Xiang·a year ago

ReleasedBug

How to reproduce

create a new http request
just paste url https://httpbin.org/get?a=1 in the url-bar

What happened:

url params not be parsed, but view fouce on param tab.

Reason

After I pasted the url, at first UrlBar#onPasteOverwrite was triggered. This hook parsed url with params correctly. But then, UrlBar#onUrlChange was triggered. onUrlChange only used the raw whole url as param without parsing.

Eventually the wrong update overwrites the previous correct update.

Linux2025.1.1

Comments (3)

Hao XiangOP·a year ago

Maybe we can parse url on the Rust side.

If so, the other problem URL params strange behavior will also be fixed.

Hao XiangOP·a year ago

I find a new way to solve this. But it might be radical.

In UrlBar#onUrlChange, we can check if the new url contains ?.

flowchart TD
  onUrlChange --> judge{new url with params?}
  judge -- N --> updateRequest
  judge -- Y --> importQuerystring

Gregory Schier

·a year ago

https://yaak.app/blog/2025.1.2